fix: add property name to rss errors #6259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3fcbdee The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
This LGTM but I'd love for @bholmesdev to take a look as well
bholmesdev
approved these changes
Feb 16, 2023
|
@y-nk Should be good to merge once you add a changeset. Run |
|
Thanks @y-nk! I added a changeset for you so we can go ahead and merge this! |
Merged
|
thanks a lot @natemoo-re 🙏🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this change?
Add more information to zod error report
Be short and concise. Bullet points can help!
When generating a rss feed with the rss function, if one prop of an item is missing, the only feedback will be
Invalid inputwithout much of where is the invalid input.Testing
I've added a prop on a string based on zod's doc here: https://github.com/colinhacks/zod/blob/master/ERROR_HANDLING.md#zodissue
Not sure if this must be tested.
Docs
No doc as well, it's rather enhanced error handling.