Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure base configuration appended to content collection styles #6182

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Feb 8, 2023

Changes

Testing

  • New test case added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023

🦋 Changeset detected

Latest commit: 7dc30e0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 8, 2023
@matthewp matthewp changed the title Fix, base appended to propagated scripts Ensure base configuration appended to content collection styles Feb 8, 2023
@MoustaphaDev
Copy link
Member

MoustaphaDev commented Feb 8, 2023

The wrong base part is fixed but, there's another bug. When rendering only the <Content /> component in the page, scripts and styles aren't injected.
I guess a partial fix is good enough to be merged, just pointing out there's another bug hiding here

@matthewp
Copy link
Contributor Author

matthewp commented Feb 8, 2023

@MoustaphaDev The test I wrong does exactly that and the scripts and styles are injected. If you have another bug then please do file an issue and I'll prioritize. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated assets do not respect base config property when using content collections
3 participants