-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs smoke error #5706
Fix docs smoke error #5706
Conversation
🦋 Changeset detectedLatest commit: d5ee40f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit 8877513.
19be60f
to
f1251d4
Compare
f1251d4
to
0ecaa4e
Compare
45d901a
to
334b7a4
Compare
"test:smoke": "turbo run build --filter=\"@example/*\" --filter=\"astro.build\" --filter=\"docs\" --output-logs=new-only --concurrency=1", | ||
"test:smoke": "turbo run build --filter=\"@example/*\" --filter=\"docs\" --output-logs=new-only --concurrency=1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't look like a astro.build
package to test so removed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, there was an astro.build
package but the checkout code was removed. We should add that back in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smost excellent fix of 2023 👏
... so far 😉 |
Changes
Add
@astrojs/sitemap
tossr.external
when loading config. It should be simplified when vitejs/vite#10939 lands.Testing
Astro smoke test should pass.
Docs
n/a bug fix