-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MD/MDX collect headings refactor #5654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13d0c0b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
Related to any renderer integration (scope)
label
Dec 20, 2022
delucis
changed the title
[WIP] MD/MDX collect headings refactor
MD/MDX collect headings refactor
Dec 20, 2022
bholmesdev
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remarkable 👏
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feat: markdown
Related to Markdown (scope)
pkg: integration
Related to any renderer integration (scope)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rehypeHeadingSlugs
to Astro users via@astrojs/markdown-remark
rehypeHeadingSlugs
in MDX integration instead of copy/paste duplication@astrojs/markdown-remark
and@astrojs/mdx
(minor == breaking pre v1)Supersedes #5646
Testing
Added tests for:
rehypeHeadingSlugs
directlyDocs
Updated the Markdown guide in withastro/docs#2216
/cc @withastro/maintainers-docs for feedback!