Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix traced warnings from unexpected token #5638

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix traced warnings from unexpected token #5638

merged 2 commits into from
Dec 19, 2022

Conversation

andreademasi
Copy link
Contributor

This PR fixes building a website when using @astrojs/vercel/serverless . It's a temporary fix until vercel/nft#311 gets fixed

Changes

  • Added an if check to ignore "Failed to parse" errors from @vercel/nft

Testing

I don't think tests are needed for this small change, if they are let me know.

Docs

It shouldn't affect user behavior

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2022

🦋 Changeset detected

Latest commit: e3e390f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 19, 2022
@aFuzzyBear aFuzzyBear requested a review from JuanM04 December 19, 2022 14:59
Copy link
Contributor

@JuanM04 JuanM04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
Before merging, could you leave the imports as they were? Just a styling preference 😄

@andreademasi
Copy link
Contributor Author

Thank you very much! Before merging, could you leave the imports as they were? Just a styling preference smile

Done!

@JuanM04 JuanM04 merged commit a467139 into withastro:main Dec 19, 2022
@astrobot-houston astrobot-houston mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants