improve a11y in new error overlay #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we should also make the "open in editor" button a button, not a link, if we are using JS for interactions
|
github-actions
bot
added
the
pkg: astro
jasikpark
commented
Dec 1, 2022
| </div> | ||
| </header> | ||
|
|
||
| <section id="message-hints"> | ||
| <section id="message"> | ||
| <span id="message-icon"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none"><path stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="1.5" d="M12 7v6m0 4.01.01-.011M12 22c5.523 0 10-4.477 10-10S17.523 2 12 2 2 6.477 2 12s4.477 10 10 10Z"/></svg> | ||
| <svg xmlns="http://www.w3.org/2000/svg" aria-hidden="true" width="24" height="24" fill="none"><path stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="1.5" d="M12 7v6m0 4.01.01-.011M12 22c5.523 0 10-4.477 10-10S17.523 2 12 2 2 6.477 2 12s4.477 10 10 10Z"/></svg> |
There was a problem hiding this comment.
maybe there should be alt text here?
matthewp
added a commit
that referenced
this pull request
Dec 14, 2022
* Add new overlay * Fix CSS errors missing the proper stacktrace * Fix names not working in some cases * Add changeset * Fix Playwright not detecting the overlay * Update E2E test * Fix tests * Small refactor, fix syntax highlight on light mode, fix code element showing even with no code * Simplier injection * Add Markdown support to CLI reporting * Fix not being able to navigate with the keyboard to the open in editor link * aria-hide some svgs (#5508) we should also make the "open in editor" button a button, not a link, if we are using JS for interactions * Implement close method so Vite can close the overlay when needed * Fix filepaths not being absolute when coming from node_modules for errors * Fix multi line errors with indentation not showing correctly * Fix entire page being scrolled to the error line in certain cases * Update docs links * Put the new error overlay behind a flag * add flag for e2e tests Co-authored-by: Caleb Jasik <[email protected]> Co-authored-by: Matthew Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should also make the "open in editor" button a button, not a link, if we are using JS for interactions