Refactor internal plugins code #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b92e564 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
commented
Nov 30, 2022
Comment on lines
-19
to
-25
| if (imports.size > 0) { | ||
| let importText = ''; | ||
| for (const [path, importName] of imports.entries()) { | ||
| importText += `import ${importName} from "${path}";\n`; | ||
| } | ||
| s.prepend(importText); | ||
| } |
There was a problem hiding this comment.
The imports variable doesn't seem used. So the size is always 0
matthewp
approved these changes
Nov 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Making some incremental refactorings through separate PRs.
The commits can be reviewed individually to see the changes.
Testing
Existing tests should pass.
Docs
Added and updated the internal READMEs for new contributors.