Prevent overcaching of astro components for HMR #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15652f0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
commented
Nov 3, 2022
| @@ -24,7 +24,7 @@ export async function handleHotUpdate( | |||
| { config, logging, compile }: HandleHotUpdateOptions | |||
| ) { | |||
| let isStyleOnlyChange = false; | |||
| if (ctx.file.endsWith('.astro')) { | |||
| if (ctx.file.endsWith('.astro') && isCached(config, ctx.file)) { | |||
There was a problem hiding this comment.
this is the only change. If the file is not cached then there's no reason to attempt this short-circuit path which will always cause false-positives.
There was a problem hiding this comment.
👍🏻 Makes total sense, nice catch!
natemoo-re
approved these changes
Nov 3, 2022
Comment on lines
+73
to
+76
| fs.writeFileFromRootSync('/src/components/Header.astro', ` | ||
| <h1>{Astro.props.title}</h1> | ||
| `); | ||
| triggerFSEvent(container, fs, '/src/components/Header.astro', 'change'); |
There was a problem hiding this comment.
I love seeing these tests inline 🥇
| @@ -24,7 +24,7 @@ export async function handleHotUpdate( | |||
| { config, logging, compile }: HandleHotUpdateOptions | |||
| ) { | |||
| let isStyleOnlyChange = false; | |||
| if (ctx.file.endsWith('.astro')) { | |||
| if (ctx.file.endsWith('.astro') && isCached(config, ctx.file)) { | |||
There was a problem hiding this comment.
👍🏻 Makes total sense, nice catch!
|
Needs a changeset (maybe?) but LGTM! |
|
oh yeah, i'll add a changeset |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
N/A, bug fix