Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote images in SSG mode #5021

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix remote images in SSG mode #5021

merged 1 commit into from
Oct 7, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Oct 7, 2022

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022

🦋 Changeset detected

Latest commit: 15481e2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 7, 2022
@matthewp matthewp requested a review from tony-sull October 7, 2022 20:43
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not quite sure how the existing remote images tests passed as-is here 🤔

@matthewp matthewp merged commit 062335d into main Oct 7, 2022
@matthewp matthewp deleted the image-remote branch October 7, 2022 21:08
@astrobot-houston astrobot-houston mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@astrojs/image] getImage utility throws 'ENOENT: no such file or directory' on astro build with remote images
2 participants