-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --base
CLI argument
#4917
Conversation
🦋 Changeset detectedLatest commit: a59becb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Might be worth adding a CLI log that could be checked by a test as well if the CLI tests are in a decent spot for it, but not 100% necessary 👍
Removing the docs-maintainers review, as the changes to |
can you update astro help for these?
interesting that |
Thanks @jasikpark! Updated the |
does this classify as a bug report? since that's the only type of issue in "new issue" that creates an actual issue? |
|
.changeset/wise-swans-live.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
'astro': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should be a minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is a minor change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for next minor
@natemoo-re can you fill out the changeset a bit more? Something like a paragraph, maybe a code example, so that this could be copy/pasted into a blog post. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
Changes
--site
and--root
and a few other CLI arguments.--base
as wellwithastro/action
) and want to automatically pass in the--site
and--base
that GitHub already knows.See also actions/configure-pages#30
Testing
Tested manually because we don't have equivalent tests for
--site
or other argumentsDocs
withastro/docs#1646
/cc @withastro/maintainers-docs