-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjusting cloudflare adapter and solid ssr to work together #4888
Merged
+12
−8
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
efbaf92
adjusting cloudflare adapter (respecting user config)
f62e23d
Merge branch 'withastro:main' into main
AirBorne04 33bda4f
only inline the framework
AirBorne04 febcfb0
Merge branch 'main' into main
AirBorne04 7274cb4
Merge branch 'main' into main
AirBorne04 fe9dded
Merge branch 'main' into main
AirBorne04 63db65c
Merge branch 'main' into main
AirBorne04 b1d389e
Merge branch 'main' into main
AirBorne04 157058b
Merge branch 'withastro:main' into main
AirBorne04 f161c5d
Merge branch 'withastro:main' into main
AirBorne04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@astrojs/cloudflare': major | ||
'@astrojs/solid-js': patch | ||
--- | ||
|
||
adjusting the build settings for cloudflare (reverting back to platform browser over neutral) | ||
adjusting the ssr settings for solidjs (to build for node) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this only fixes bugs then this shouldn't be a major. Maybe you were just being conservation here, or can you tell me what this breaks?
If this is a true breaking change I think we should have more explanation of the change in the changeset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted this one to minor