Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [astro add] fetch failure #4703

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

bholmesdev
Copy link
Contributor

Changes

Move applyPolyfill() to top of astro add flow

Testing

Manual testing

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

🦋 Changeset detected

Latest commit: 2fb7689

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 9, 2022
@matthewp
Copy link
Contributor

matthewp commented Sep 9, 2022

Failing test is a known flakiness, since this is urgent let's just merge.

@bholmesdev bholmesdev merged commit d28f701 into main Sep 9, 2022
@bholmesdev bholmesdev deleted the fix/astro-add-fetch-undefined branch September 9, 2022 20:56
@astrobot-houston astrobot-houston mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants