Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image integration's types not including Vite's types #4534

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

Princesseuh
Copy link
Member

Changes

The Image integration's types didn't refer to client-base.d.ts, as such numerous types were lost when using them. Notably import.meta.env

Testing

Tested manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

🦋 Changeset detected

Latest commit: 79f04d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 29, 2022
@Princesseuh Princesseuh merged commit b8a80bc into main Aug 29, 2022
@Princesseuh Princesseuh deleted the missing-reference-image branch August 29, 2022 15:06
@astrobot-houston astrobot-houston mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants