Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renderer keyword to alpinejs integration #4501

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Add renderer keyword to alpinejs integration #4501

merged 2 commits into from
Aug 26, 2022

Conversation

mhdcodes
Copy link
Contributor

@mhdcodes mhdcodes commented Aug 26, 2022

Changes

Results on the docs: https://deploy-preview-1417--astro-docs-2.netlify.app/en/guides/integrations-guide/

Before:
image

After:
image

Testing

Docs

This will auto update the docs.

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2022

🦋 Changeset detected

Latest commit: eefc983

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 26, 2022
@mhdcodes
Copy link
Contributor Author

PR created after a discussion with @sarah11918 over discord.

https://discord.com/channels/830184174198718474/853350631389265940/1012755607574552636

@sarah11918
Copy link
Member

Thanks, @mohammed-elhaouari!

@FredKSchott - Can you please review this and confirm whether you agree we should move Alpine up into the category with the other framework renderers? I asked for this PR "just in case" a few of us in Docs think it makes sense there. But, since Basically-Midnight-Fred didn't include this in the first place, I'm going to leave the call to you!

@sarah11918 sarah11918 requested a review from FredKSchott August 26, 2022 17:04
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mohammed-elhaouari, LGTM!

@FredKSchott FredKSchott merged commit 17e2178 into withastro:main Aug 26, 2022
@astrobot-houston astrobot-houston mentioned this pull request Aug 26, 2022
@mhdcodes mhdcodes deleted the update-category-for-alpinejs branch August 26, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants