refactor the JSX plugin, improve performance #4405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@jsxImportSource
pragma over import scanning. I had assumed that the explicit pragma always beat out the implicit import scanning, and would make the case here that ignoring an explicit pragma is a bug. This change would only impact a user who had a@jsxImportSource
to one framework and then ESM imports to another. I don't think that's realistic, but I thought I'd call it out here in case anyone feels differently.Testing
Docs