Preserve all error stack lines #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8963353 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
commented
Aug 17, 2022
Comment on lines
-238
to
+241
| args.push(dim(cleanErrorStack(err.stack))); | ||
| args.push(dim(err.stack)); | ||
| } else if (err.stack) { | ||
| args.push(` ${bold('Stacktrace:')}`); | ||
| args.push(dim(cleanErrorStack(err.stack))); | ||
| args.push(dim(err.stack)); |
There was a problem hiding this comment.
cleanErrorStack is removed as it should already be cleaned by collectErrorMetadata.
natemoo-re
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #4357
Preserve all error stack lines to avoid hiding important information. I'm not sure if this may expose more dirty messages, but we could monitor along as we go.
Before:
After:
Note: I also tried parsing the stack to split out the stack and frame, but it doesn't work with Vite's overlay as it expects frames to start with a
|pipe.Testing
Tested manually with the repro at #4357
Docs
N/A