Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relaxed and default TypeScript settings not working #4183

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

Princesseuh
Copy link
Member

Changes

Fix the default and relaxed settings not working in create-astro, we should only copy when the user selected either strict or stricter, as the default template is already in the template

Testing

I did this PR on my phone at 5am, so cannot test right now

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2022

🦋 Changeset detected

Latest commit: bda9f29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Aug 6, 2022
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In a future commit, we should make the copy that exists in the repo the strictest (instead of the most relaxed) so that we can confirm no TS errors in CI across all of our examples.

@FredKSchott FredKSchott merged commit 77c018e into main Aug 6, 2022
@FredKSchott FredKSchott deleted the Princesseuh-patch-1 branch August 6, 2022 14:04
@astrobot-houston astrobot-houston mentioned this pull request Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants