Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send body with HEAD and GET on node integration #4105

Merged
merged 5 commits into from
Aug 2, 2022
Merged

Do not send body with HEAD and GET on node integration #4105

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
692de9e
Do not send body with HEAD and GET on node integration
dimitrov-adrian Jul 31, 2022
9c1da4a
Create seven-suits-sit.md
natemoo-re Aug 1, 2022
7ae5c02
Merge branch 'main' into fix-node-integration-request
natemoo-re Aug 1, 2022
91713ce
Merge branch 'main' into fix-node-integration-request
natemoo-re Aug 2, 2022
8ee7555
Merge branch 'main' into fix-node-integration-request
natemoo-re Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/astro/src/core/app/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ function createRequestFromNodeRequest(req: IncomingMessage, body?: Uint8Array):
let url = `http://${req.headers.host}${req.url}`;
let rawHeaders = req.headers as Record<string, any>;
const entries = Object.entries(rawHeaders);
const method = req.method || 'GET';
let request = new Request(url, {
method: req.method || 'GET',
method,
headers: new Headers(entries),
body,
body: ['HEAD', 'GET'].includes(method) ? null : body,
});
if (req.socket?.remoteAddress) {
Reflect.set(request, clientAddressSymbol, req.socket.remoteAddress);
Expand Down