Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: (patching old PR) Check node version and find acceptable host accordingly #4032

Merged
merged 6 commits into from
Jul 23, 2022
Merged

Fix: (patching old PR) Check node version and find acceptable host accordingly #4032

merged 6 commits into from
Jul 23, 2022

Conversation

arimgibson
Copy link
Contributor

Changes

Testing

See reasoning for no tests on #3599

Docs

This change is not visible, meaning that documentation does not need to be updated.

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2022

🦋 Changeset detected

Latest commit: 05afb4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 23, 2022
@arimgibson
Copy link
Contributor Author

Not sure if removing those changesets was the right move, but noticed that the bot had included data about unrelated changesets. Hope I didn't make it more difficult for maintainers 😃

@natemoo-re
Copy link
Member

Thanks for the PR @arimgibson! I reverted the removal of the changesets—the bot including those extra packages won't mess anything up, not sure why that's happening.

@natemoo-re natemoo-re merged commit beddf07 into withastro:main Jul 23, 2022
@astrobot-houston astrobot-houston mentioned this pull request Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants