Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: new legacy.astroFlavoredMarkdown flag #4016

Merged
merged 31 commits into from
Jul 22, 2022
Merged

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jul 21, 2022

Changes

  • Remove old markdown.mode: 'md' | 'mdx' option
  • Make "plain" markdown compilation the new default 🥳
  • Add legacy.astroFlavoredMarkdown to reenable our component and expression processing

Testing

Update test suites to use legacy.astroFlavoredMarkdown where applicable. I left this flag off for any markdown tests that don't test components or JSX expressions.

Docs

Docs PR #1090 deprecates the "Authoring markdown" section and adds config docs for the new legacy flag

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

🦋 Changeset detected

Latest commit: 43041b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
astro Minor
@astrojs/markdown-component Minor
@astrojs/markdown-remark Minor
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) feat: markdown Related to Markdown (scope) labels Jul 21, 2022
@natemoo-re natemoo-re mentioned this pull request Jul 21, 2022
20 tasks
@bholmesdev bholmesdev marked this pull request as draft July 21, 2022 21:57
@bholmesdev bholmesdev force-pushed the feat/new-legacy-md-flag branch from e541c38 to 51c2772 Compare July 21, 2022 22:06
* @see https://docs.astro.build/en/guides/integrations-guide/mdx/
* Default: false
*/
astroFlavoredMarkdown?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tony-sull If you want legacy.astroFlavoredMarkdown to show up in docs, then I think you need to put your content here.

@tony-sull tony-sull marked this pull request as ready for review July 22, 2022 21:11
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 22, 2022
@tony-sull tony-sull force-pushed the feat/new-legacy-md-flag branch from 6384a94 to 6a7240a Compare July 22, 2022 21:33
@github-actions github-actions bot removed the pkg: integration Related to any renderer integration (scope) label Jul 22, 2022
@tony-sull tony-sull merged commit 00fab4c into main Jul 22, 2022
@tony-sull tony-sull deleted the feat/new-legacy-md-flag branch July 22, 2022 22:45
@astrobot-houston astrobot-houston mentioned this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants