Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issue #385 #392

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Fix/issue #385 #392

merged 4 commits into from
Jun 11, 2021
+69 −3

Conversation

Hanawa02
Copy link
Contributor

@Hanawa02 Hanawa02 commented Jun 11, 2021 •
edited
Loading

Changes

  • Apply favicon to the docs template
  • Fix Sidebar category headers aren't clickable
  • Improve Docs example documentation

Testing

In \examples\docs:

  • run npm install
  • run npm run start

The project now should have the following navigation items Introduction, Getting Started, and Example.
The Introduction item should be a link to the root page.
The favicon should now be displayed (on browsers that support SVG images).

  • Tests are passing
  • Tests updated where necessary

Docs

  • Docs / READMEs updated
  • Code comments added where helpful

@Hanawa02 Hanawa02 requested a review from a team as a code owner June 11, 2021 18:37
@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 10a3691

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 11, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/astro-www/2GYxQyCgSrSLsD5kuCihbMP4Byz4
✅ Preview: https://astro-www-git-fork-hanawa02-fix-issue-385-pikapkg.vercel.app

@duncanhealy duncanhealy changed the title Fix/issue 385 Fix/issue #385 Jun 11, 2021
@matthewp
Copy link
Contributor

Looks great! Thanks so much!

@matthewp matthewp merged commit 348d829 into withastro:main Jun 11, 2021
natemoo-re pushed a commit that referenced this pull request Jun 2, 2022
fix(#392): ensure link tags are rendered as void elements
d99881f
natemoo-re added a commit that referenced this pull request Jun 2, 2022
@natemoo-re
Fix <link> tag not being self-closing (#3506)
d41540c 
* fix(#392): ensure link tags are rendered as void elements

* test: ensure html does not include a `</link>` end tag

* chore: add changeset
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@natemoo-re
Fix <link> tag not being self-closing (withastro#3506)
2e7b877 
* fix(withastro#392): ensure link tags are rendered as void elements

* test: ensure html does not include a `</link>` end tag

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hanawa02 @matthewp