update telemetry to support more anonymized project id #3713
Conversation
🦋 Changeset detectedLatest commit: 58cf55d The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
| const packages = flags._.slice(3) as string[]; | ||
| telemetry.record( | ||
| event.eventCliSession({ | ||
| astroVersion: process.env.PACKAGE_VERSION ?? '', |
There was a problem hiding this comment.
this isn't needed, since astroVersion is passed to the AstroTelemetry constructor above.
| viteVersion: getViteVersion(), | ||
| nodeVersion: process.version.replace(/^v?/, ''), | ||
| configKeys: userConfig ? configKeys(userConfig, '') : undefined, | ||
| // Config Values | ||
| config: configValues, | ||
| flags: cliFlags, | ||
| // Optional integrations | ||
| optionalIntegrations: userConfig?.integrations?.length - integrations?.length, |
There was a problem hiding this comment.
this was added as a "nice-to-have" in a PR that was fixing a different bug, but I don't think this is actually valuable to us so I removed it.
| @@ -108,7 +107,7 @@ export function eventCliSession( | |||
| : undefined, | |||
| markdown: userConfig?.markdown | |||
| ? { | |||
| mode: userConfig?.markdown?.mode, | |||
There was a problem hiding this comment.
mode is no longer supported but the types were out of date, so this wasn't caught. Removed this and added drafts instead.
| export interface AstroTelemetryOptions { | ||
| version: string; | ||
| } | ||
| import { getProjectInfo, ProjectInfo } from './project-info.js'; |
There was a problem hiding this comment.
Note: All changes in this file are from refactoring and cleanup and small bug fixing. Lots of little things tackled, but the meat of the change (the new project ID) lives in project-info.js.
| return fetch(ASTRO_TELEMETRY_ENDPOINT, { | ||
| method: 'POST', | ||
| body: JSON.stringify(body), | ||
| headers: { 'content-type': 'application/json' }, | ||
| }) | ||
| .catch(noop) |
There was a problem hiding this comment.
moved this post handling logic into the call telemetry/src/index.ts
|
Need a changeset |
* update telemetry to support more anonymized project id * Create strange-laws-kick.md * respond to nate feedback
Changes
projectIdto be more anonymous: it's now based on a commit hash instead of your git remote. This means that even if the hash is somehow reversed, it is no longer possible to identify the project.project-info.tsfile.Refactoring
Testing
Docs