Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove post-rendering head injection #3679

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Remove post-rendering head injection #3679

merged 3 commits into from
Jun 23, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Removes the delayed head rendering. Instead rendering occurs at the place where the compiler finds the end of the head.
  • This is in prep for streaming support

Testing

  • All existing tests should pass

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: eafe358

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 22, 2022
@matthewp matthewp force-pushed the remove-head-injection branch 2 times, most recently from 2586c94 to c1c7c3f Compare June 23, 2022 13:06
@matthewp matthewp marked this pull request as ready for review June 23, 2022 13:42
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Looks great.

@matthewp matthewp force-pushed the remove-head-injection branch from 5f32bf9 to 18ea6e6 Compare June 23, 2022 19:09
@matthewp matthewp merged commit fa7ed3f into main Jun 23, 2022
@matthewp matthewp deleted the remove-head-injection branch June 23, 2022 19:37
@github-actions github-actions bot mentioned this pull request Jun 23, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Remove post-rendering head injection

* Adds a changeset

* Use a layout component for vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants