Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import.meta.env without trailing dot/var in Markdown #3675

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

hippotastic
Copy link
Contributor

Changes

  • Improves my previous fix that only allowed writing import.meta.env. (with trailing dot) in Markdown files to also work without a trailing dot or var. It is now possible to have the text import.meta.env anywhere in a Markdown file without causing a compiler error.

Testing

  • Extended existing test case.
  • Ran all tests locally.

Docs

  • Not a visible change.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: f8dd234

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 22, 2022
@matthewp
Copy link
Contributor

Can you rebase this with main? Should be all green once you do that.

@matthewp matthewp merged commit ef6282d into withastro:main Jun 22, 2022
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
@hippotastic hippotastic deleted the fix/import-meta-env-without-var branch June 22, 2022 13:12
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants