simplify a complex peer semver used by astro add #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b279a6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
tony-sull
reviewed
Jun 17, 2022
packages/astro/src/core/add/index.ts
Outdated
| @@ -407,7 +407,7 @@ async function getInstallIntegrationsCommand({ | |||
| .map<[string, string | null][]>((i) => [[i.packageName, null], ...i.dependencies]) | |||
| .flat(1) | |||
| .filter((dep, i, arr) => arr.findIndex((d) => d[0] === dep[0]) === i) | |||
| .map(([name, version]) => (version === null ? name : `${name}@${version}`)) | |||
| .map(([name, version]) => (version === null ? name : `${name}@${version.split(' ').pop()}`)) | |||
There was a problem hiding this comment.
Would this end up always installing react@^18?
It'd be very cool for astro add to prompt me for which version of react I want,
**Which version of react would you like to install?**
◯ ^17.0.2
◯ ^18.0.0
There was a problem hiding this comment.
Agreed! I still think we can get this in and add that as a future enhancement too 👍
bholmesdev
reviewed
Jun 18, 2022
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* fix peer semver used by astro add * Create pink-shirts-mix.md * update with regex over `' '` split Co-authored-by: Ben Holmes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro addoutputastro add reactis run with yarn (reported by @Princesseuh)This isn't perfect, but I've never seen a semver string that this wouldn't work for. The next step would be evaluating the semver using a more complex semver-aware parser. I'd rather cross that bridge when we encounter the need.
Testing
Docs