Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass optimizeDeps.include to silence build warning #3507

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jun 2, 2022

Changes

  • Silences Vite warning that runs for every build
  • Warning states...
    (!) Could not auto-determine entry point from rollupOptions or html files and there are no explicit optimizeDeps.include patterns. Skipping dependency pre-bundling.
    
  • Fix was to add an explicit optimizeDeps.include (by default [])
  • Don't forget a changeset! pnpm exec changeset

Testing

Manually, we don't test build logs right now

Before
Screen Shot 2022-06-02 at 12 25 25 PM

After
Screen Shot 2022-06-02 at 12 25 05 PM

Docs

N/A, QoL improvement only

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

🦋 Changeset detected

Latest commit: 9ca5cf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 2, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Interesting that undefined logs the warning and [] doesn't

@natemoo-re natemoo-re merged commit cf2fb30 into main Jun 2, 2022
@natemoo-re natemoo-re deleted the fix/build-warning branch June 2, 2022 18:04
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix(build): pass `optimizeDeps.include` to silence build warning

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants