-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: alias astro to @types/astro #3503
Conversation
🦋 Changeset detectedLatest commit: 7d349c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
66b7399
to
c8816d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing fix, thanks for looking into this! 🙌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that's a great catch, looks good to me too!
* fix: alias astro to @types/astro * fix: handle resolve.alias being array * chore: add integrations patch to changeset * chore: remove empty file
Changes
fixes: withastro/compiler#378
Aliases imports for
astro
to@types/astro
c8816d4 and updates Netlify and Deno integrations to handlevite.resolve.alias
as an array b15ca78Only the types live under
astro
but without alias vite resolves import topackages/astro/astro.js
Testing
import type { MarkdownInstance } from 'astro'
is presentDocs
No docs needed, this is fix for expected behaviour