Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [create astro] git step #3227

Merged
merged 9 commits into from
Apr 29, 2022
Merged

Feat: [create astro] git step #3227

merged 9 commits into from
Apr 29, 2022

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Apr 27, 2022

Changes

  • Add step to initialize empty git repository during create-astro setup
  • Remove git from "next steps" for better copy-pastability
  • Note: does not add all and commit "initial commit!" Since the user may run pnpm install and generate a lockfile after-the-fact, or run astro add post-setup, they may have more to commit. This hopefully prevents confusion there.

Testing

Testing this new step "exists" didn't seem very productive. Just updated existing tests!

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2022

🦋 Changeset detected

Latest commit: 4f87ae9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: create-astro Related to the `create-astro` package (scope) test labels Apr 27, 2022
@bholmesdev bholmesdev force-pushed the feat/create-astro-git-step branch from efcc85a to 651c192 Compare April 28, 2022 14:35
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, had a few small questions.

packages/create-astro/src/index.ts Outdated Show resolved Hide resolved
packages/create-astro/src/index.ts Outdated Show resolved Hide resolved
@FredKSchott
Copy link
Member

LGTM!

@bholmesdev bholmesdev merged commit c8f5fa3 into main Apr 29, 2022
@bholmesdev bholmesdev deleted the feat/create-astro-git-step branch April 29, 2022 15:45
@github-actions github-actions bot mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants