Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect externals in vercel adapter #3106

Closed
wants to merge 1 commit into from
Closed

Conversation

FredKSchott
Copy link
Member

Changes

  • I was helping @theobr with puppeteer and ran into this issue.
  • I marked "chrome-aws-lambda", "puppeteer-core" as external in my Astro config, but then the vercel adapter blew this away and bundled them all again.
  • This is a quick fix. @JuanM04 is there a reason to use esbuild.build() instead of esbuild.transform() since we're only ever transforming a single file from ESM -> CJS?

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2022

⚠️ No Changeset found

Latest commit: eea7fea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Apr 14, 2022
@JuanM04
Copy link
Contributor

JuanM04 commented Apr 14, 2022

there a reason to use esbuild.build() instead of esbuild.transform() since we're only ever transforming a single file from ESM -> CJS?

It's transforming and bundling dependencies. In my other PR about this (#3051), it only bundles the dependencies

@FredKSchott
Copy link
Member Author

ah, yea I'm realizing this is more complicated than I thought. Closing this in favor of figuring out #3051 first

@FredKSchott FredKSchott deleted the vercel-deps-fix branch April 14, 2022 02:19
@JuanM04
Copy link
Contributor

JuanM04 commented May 6, 2022

I was helping TheoBr with puppeteer and ran into this issue.

Hey @FredKSchott, do you have a reproduction? I think I've fixed it (or could be fixed) in #3216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants