fix build base bug #3068
Merged
fix build base bug #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5961975 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
1 task
tony-sull
approved these changes
Apr 12, 2022
| @@ -191,7 +191,7 @@ async function generatePath( | |||
| } | |||
|
|
|||
| const ssr = isBuildingToSSR(opts.astroConfig); | |||
| const url = new URL(origin + pathname); | |||
| const url = new URL(opts.astroConfig.base + pathname.substring(1), origin); | |||
There was a problem hiding this comment.
I think the answer here is yes, but is it safe to always assume pathname will start with a / here?
If not, may be a good spot for a regex that only strips the first character if it's a /
There was a problem hiding this comment.
yea, agreed. better safe than sorry
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* fix ssr url search params bug * fix build base bug * safer slash removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
baseconfigTesting
Docs