-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor smoke tests to use submodules #2702
Conversation
|
uses: actions/checkout@v3 | ||
with: | ||
submodules: 'recursive' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the extent of the changes to our actions. This pulls in the submodules recursively, so they always reflect the latest commit to main
every time they run.
[submodule "smoke/docs"] | ||
path = smoke/docs | ||
url = [email protected]:withastro/docs.git | ||
branch = main | ||
[submodule "smoke/astro.build"] | ||
path = smoke/astro.build | ||
url = [email protected]:withastro/astro.build.git | ||
branch = main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This points ./smoke/docs
to [email protected]:withastro/docs.git
and smoke/astro.build
to [email protected]:withastro/astro.build.git
. They both should reflect the main
branch.
By default, git pull
doesn't populate these directories unless you explicitly opt-in to that behavior (which most users won't need to do)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should mention that users won't do this often, but our smoke test action can specifically populate them just for that run. Seems much better than the previous system!
Needs to be rebased :( |
23d4d8d
to
fbceb7d
Compare
@natemoo-re from my comment here: #2618 (comment) I'd still love to try our current system for another week, but if it's already been a pain for maintainers in so little time then I'm +1 on this PR. I'm just surprised that this has impacted rebasing since we should never be touching that directory... but I guess they still find their way into the rebase diff? Regardless, +1 if you feel strongly. One thing to watch out for, that I realized in the smoke sync script: checking out these git submodules locally and then re-running |
Thanks @FredKSchott! Yeah unfortunately the automatic sync PR merge commits still get picked up when you rebase from I'll give the |
* chore: delete inlined repos * refactor: move smoke tests to submodules * chore: remove smoke sync action * chore: update ci to fetch submodules for smoke test only * chore: fix ci script * feat: delete inlined smoke tests * fix: update lockfile to exclude smoke tests * chore(ci): ensure smoke tests can pass in CI
Changes
git submodules
to manage theastro.build
anddocs
smoke tests. These will only be fetched for the smoke test action and will always fetch the latest commit tomain
. It's automatic and doesn't require an action to sync these nightly.git pull
won't fetch submodules by default.Testing
CI
Docs
N/A