Expose private .env variables to import.meta.env during SSR
#2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1acfa4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
This was referenced Feb 17, 2022
FredKSchott
reviewed
Feb 17, 2022
FredKSchott
reviewed
Feb 17, 2022
FredKSchott
reviewed
Feb 17, 2022
jonathantneal
approved these changes
Feb 18, 2022
FredKSchott
reviewed
Feb 18, 2022
| if (!/\benv\b/.test(source)) return source; | ||
|
|
||
| if (typeof privateEnv === 'undefined') { | ||
| privateEnv = getPrivateEnv(config, astroConfig); |
There was a problem hiding this comment.
a little worried about caching issues here if Vite has automatic-reloading of .env files. Not enough to block, just a callout that could deserve a TODO if someone runs into this issue in the future.
There was a problem hiding this comment.
Good callout. Just checked and Vite does not hot-reload .env files.
|
LGTM with a failing test. Reminder that we don't need to race the train on this one: we can get it out in the next release if needed |
natemoo-re
force-pushed
the
fix/process-env
branch
from
875c58a to
dd92092
Compare
natemoo-re
force-pushed
the
fix/process-env
branch
from
dd92092 to
2745569
Compare
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
…astro#2612) * chore(examples): add env-vars example * feat: improve import.meta.env support * chore: add changeset * test: update astro-envs test * refactor: cleanup code based on feedback * fix: import.meta guard * fix: update memory test threshold to 10%
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
…astro#2612) * chore(examples): add env-vars example * feat: improve import.meta.env support * chore: add changeset * test: update astro-envs test * refactor: cleanup code based on feedback * fix: import.meta guard * fix: update memory test threshold to 10%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.envvariables toimport.meta.envon the server (during SSR).PUBLIC_variables toimport.meta.envon the client.env-varsTesting
Tested manually in example
Docs
Updated in PR