Pass children to client components even if they do not render them #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad69806 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
jonathantneal
approved these changes
Feb 15, 2022
matthewp
commented
Feb 15, 2022
| if(fragment == null) { | ||
| // If there is no child fragment, check to see if there is a template. | ||
| // This happens if children were passed but the client component did not render any. | ||
| let template = roots[0].querySelector(`template[data-astro-template]`); |
There was a problem hiding this comment.
Note to self, this is going to check for this template any time there is not an astro-fragment. We can probably short circuit this check so it's only done when needed.
matthewp
force-pushed
the
donut-no-ssr
branch
from
c369396 to
1d15dc3
Compare
|
Put this back to draft as I want to make one small change but need to test it locally first. |
tony-sull
approved these changes
Feb 16, 2022
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
…ithastro#2588) * Pass children to client components even if they do not render them * Handle when no children are provided * Adds a changeset * Use roots directly i guess * Use an attribute to signal that the template is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<astro-fragment>but there are children, we know that means they did not render the children.<template data-astro-template>inside of the<astro-root>. In the client the HTML inside of this template becomes the children passed to the client component.Testing
Tests added.
Docs
Not needed, bug fix.