Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve relative imports from hoisted scripts (static build) #2581

Merged
merged 15 commits into from
Feb 15, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Test added

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2022

🦋 Changeset detected

Latest commit: 1851c66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 14, 2022
Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @matthewp. For this and for watching! 😂

@matthewp
Copy link
Contributor Author

Windows failing for predictable reasons, will fix.

@github-actions github-actions bot added the test label Feb 14, 2022
@matthewp matthewp marked this pull request as draft February 15, 2022 17:36
@matthewp matthewp force-pushed the hoisted-relative-sb branch from 8f630c6 to fae954e Compare February 15, 2022 20:50
@matthewp matthewp marked this pull request as ready for review February 15, 2022 21:03
@matthewp matthewp force-pushed the hoisted-relative-sb branch from fae954e to ff336c5 Compare February 15, 2022 21:04
@matthewp matthewp merged commit ec6f148 into main Feb 15, 2022
@matthewp matthewp deleted the hoisted-relative-sb branch February 15, 2022 21:55
This was referenced Feb 15, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
…ro#2581)

* Resolve relative imports from hoisted scripts

* Adds a changeset

* Windows fix

* Set a longer timeout for the Lit test

* blah

* Handle windows properly

* Only if the from is astro

* Windows debugging

* This might fix it

* another try

* use only

* More debugging

* Does this work

* Final cleanup

* Update the lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Static build - Inline hoisted scripts relative paths are not working
2 participants