-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for scss in static build #2522
Conversation
🦋 Changeset detectedLatest commit: 55ed808 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: 8a62dda 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61faa3aaf2df3e000881fd55 😎 Browse the preview: https://deploy-preview-2522--astro-docs-2.netlify.app |
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: 55ed808 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61fab05a5d40f10007ca1035 😎 Browse the preview: https://deploy-preview-2522--astro-docs-2.netlify.app |
Is the CSS always processed by PostCSS (or the appropriate superset parser)? If not, may it be? I think this is critical. I believe we cannot support every possible superset without a conforming parser, and the (previous?) internal one (written in Go?) breaks a lot of valid CSS, including container queries. |
Yes, this doesn't change how compilation works. The Go compiler calls out to JS and that's what CSS compiling actually occurs. I should have said that it happens "in the compilation" step instead of in the compiler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thanks for the clarification. 👍
* Fix support for scss in static build * Adds a changeset * Pass the normalizedID to transformWithVite
Changes
Testing
No HMR unit tests exists, tested via the example app (update is included here).
Docs
Bug fix only