Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor dev to use vite server #2494

Merged
merged 1 commit into from
Jan 31, 2022
Merged

refactor dev to use vite server #2494

merged 1 commit into from
Jan 31, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Jan 29, 2022 •
edited
Loading

Changes

  • Removes our custom dev server in favor of hooking directly into Vite.
  • Solves a bunch of bugs (ex: no more fighting with the vite HTML plugin)
  • Adds a bunch of new features (ex: https support via vite's server.https config)
  • simplifies the codebase (no more DevServer, reimplementing connect, etc.)
  • Prior art: this is how sveltekit does things, which is a nice vote of confidence for the approach.

Testing

  • Covered by existing tests.

Docs

  • N/A, not user facing.

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: f46afa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 29, 2022
@netlify
Copy link

netlify bot commented Jan 29, 2022 •
edited
Loading

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: f46afa9

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f4fa2ee21d0400070f19dc

😎 Browse the preview: https://deploy-preview-2494--astro-docs-2.netlify.app

@FredKSchott FredKSchott force-pushed the refactor-dev-server-1 branch from 432577b to 4418d6e Compare January 29, 2022 08:23
@FredKSchott FredKSchott force-pushed the refactor-dev-server-1 branch from 4418d6e to f46afa9 Compare January 29, 2022 08:26
@matthewp
Copy link
Contributor

Did you test this with the subpath example? We were handling it manually in our old dev server. That would be my only concern. There are tests though so presumably the fact that those are passing means it's good. Happy to see this.

@FredKSchott
Copy link
Member Author

Yup! I think this even fixes/addresses #2348. Here's astro docs site working on /docs:

Screen Shot 2022-01-29 at 8 48 49 AM

@matthewp matthewp merged commit d7149f9 into main Jan 31, 2022
@matthewp matthewp deleted the refactor-dev-server-1 branch January 31, 2022 19:44
@github-actions github-actions bot mentioned this pull request Jan 31, 2022
Merged
This was referenced Feb 15, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
refactor dev to use vite server (withastro#2494)
546f4eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @matthewp