Deprecate unescaped HTML inside of expressions #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb50e61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: cb50e61 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f85cb2a7982f00079d71a8 😎 Browse the preview: https://deploy-preview-2489--astro-docs-2.netlify.app |
natemoo-re
changed the title
|
Is there really a point of referencing something that does not exist? It can always be added at a later date. |
| @@ -41,4 +41,4 @@ if (content) { | |||
| html = htmlContent; | |||
| --- | |||
|
|
|||
| {html ? html : <slot />} | |||
| {html ? <Fragment set:html={html} /> : <slot />} | |||
natemoo-re
force-pushed
the
feat/automatic-escaping
branch
from
459bb28 to
cb50e61
Compare
Merged
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* feat: implement automatic escaping * feat: deprecate automatic escaping * fix: cast unescapeHTML as string * fix: slot fallback behavior * fix: unescaped content * Update escape.ts * Update escape.ts * feat: update internal components to use `set:html` * chore: update compiler * chore: update changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Does not require compiler changes!
Deprecates passing unescaped HTML inside of an expression (like
{"<style>div { color: red; }</style>"}, logs a warning when unescaped HTML is encounteredDoes NOT enable automatic escaping inside of expressions! This is a simple toggle that can be enabled in a follow-up PR to be released in the next minor version.
Adds an internal
UnescapedStringprimitive to powerset:htmland internal renderingTesting
Tested manually in the examples.
TODO: ensure all examples are working as expected.
Docs
TBD.