Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📘 DOC: Docsearch discern language #2472

Closed
wants to merge 20 commits into from
Closed

📘 DOC: Docsearch discern language #2472

wants to merge 20 commits into from

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Jan 26, 2022

Migrated to: withastro/docs#119

Changes

  • Upgraded docsearch
  • Removed unnecessary lang tag in markdown
  • Re-added facet filters

BEFORE merging this PR, we need to wait for this PR to get merged that tells Algolia to index the languages.

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2022

⚠️ No Changeset found

Latest commit: 25e994c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added docs pkg: example Related to an example package (scope) labels Jan 26, 2022
@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 09371f7

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f86da67fc8b80008405a11

😎 Browse the preview: https://deploy-preview-2472--astro-docs-2.netlify.app

@jonathantneal
Copy link
Contributor

Hey @JuanM04. we recently migrated our docs site over to https://github.com/withastro/docs

I have another PR to remove our old version of the docs from this monorepo, #2517.

I can make sure your work gets added into that repository. Would you be interested in making that PR? You don’t have to, but I would like you to get the commit credit. I can also attribute the improvement to you, but it would not be the same as a signed commit from your machine.

@JuanM04 JuanM04 closed this Feb 7, 2022
@JuanM04 JuanM04 deleted the docsearch-i18n branch February 7, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants