Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vite-plugin-fetch #2460

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Remove vite-plugin-fetch #2460

merged 1 commit into from
Jan 25, 2022

Conversation

jonathantneal
Copy link
Contributor

Changes

  • Removes vite-plugin-fetch
  • This plugin is not used in the project.

Testing

removes unused code only

Docs

removes unused code only

Remove vite-plugin-fetch
40191af 
This plugin is not used in the project
@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2022

⚠️ No Changeset found

Latest commit: 40191af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 25, 2022
@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 40191af

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f00ad2ff280f0007ef3a8a

😎 Browse the preview: https://deploy-preview-2460--astro-docs-2.netlify.app

@jonathantneal jonathantneal changed the title [WIP] Remove vite-plugin-fetch Remove vite-plugin-fetch Jan 25, 2022
@jonathantneal jonathantneal marked this pull request as ready for review January 25, 2022 14:44
@matthewp
Copy link
Contributor

lgtm

@jonathantneal jonathantneal merged commit 4c4c801 into main Jan 25, 2022
@jonathantneal jonathantneal deleted the jn.remove-vite-plugin-fetch branch January 25, 2022 14:49
okikio
okikio requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@okikio okikio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also remove vite-plugin-fetch from the astro package.json
https://github.com/withastro/astro/search?q=vite-plugin-fetch&type=

@boehs boehs mentioned this pull request Jan 25, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@jonathantneal
Remove vite-plugin-fetch (withastro#2460)
05612ee 
This plugin is not used in the project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okikio okikio okikio requested changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathantneal @matthewp @okikio