Upgrade Vite to latest #2424

natemoo-re · 2022-01-19T23:37:28Z

Changes

Another attempt at update to [email protected] #1866 (that branch had gotten unwieldy.)
Un-vendors Vite, upgrades to [email protected] as there are some fixes there that haven't landed in [email protected]

Testing

Tracking tests in CI

Docs

N/A

changeset-bot · 2022-01-19T23:37:32Z

🦋 Changeset detected

Latest commit: 7d1479b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
astro	Minor
@astrojs/renderer-svelte	Minor
@astrojs/renderer-vue	Minor
@astrojs/renderer-solid	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2022-01-19T23:41:51Z

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 56f75c1

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f8553d3a613b000876b20a

😎 Browse the preview: https://deploy-preview-2424--astro-docs-2.netlify.app

matthewp · 2022-01-20T18:41:40Z

Blocked by vitejs/vite#6576

matthewp · 2022-01-21T15:54:13Z

This is blocked by another Vite bug that I'm submitting a PR for shortly.

matthewp · 2022-01-21T16:40:47Z

Blocked by vitejs/vite#6589

natemoo-re · 2022-01-24T22:52:35Z

Looks like the final issues caused by Svelte are now passing! Just two issues left.

natemoo-re · 2022-02-05T00:20:58Z

This is super close, one last absolute path issue on Windows.

natemoo-re · 2022-02-08T22:35:24Z

examples/with-nanostores/src/pages/index.astro

@@ -3,7 +3,6 @@
 import AdminsReact from '../components/AdminsReact.jsx';
 import AdminsSvelte from '../components/AdminsSvelte.svelte';
 import AdminsVue from '../components/AdminsVue.vue';
-import AdminsPreact from '../components/AdminsPreact.jsx';


This is a change worth calling out... Had to drop the @nanostores/preact usage from this example to get everything passing. I think there's some issue with deduping going on, but I'm hoping it's just in our monorepo. Will be sure to check this once we cut a release.

Thanks for the callout. If you're worried about not being able to resolve this before end of week, I'd suggest creating an issue to track adding @nanostores/preact back.

natemoo-re · 2022-02-08T22:35:55Z

packages/astro/package.json

@@ -106,7 +105,7 @@
    "strip-ansi": "^7.0.1",
    "supports-esm": "^1.0.0",
    "tsconfig-resolver": "^3.0.1",
-    "vite": "~2.6.10",
+    "vite": "^2.8.0-beta.7",


No more vendored vite! It's a real dependency.

natemoo-re · 2022-02-08T22:36:23Z

packages/astro/src/core/create-vite.ts

-const ALWAYS_NOEXTERNAL = new Set([
-	'astro', // This is only because Vite's native ESM doesn't resolve "exports" correctly.
-]);


This comment is no longer true, so astro can now be optimized by Vite.

natemoo-re · 2022-02-08T22:36:48Z

packages/astro/src/runtime/server/hydration.ts

-import { valueToEstree } from 'estree-util-value-to-estree';
-import * as astring from 'astring';


These packages we needlessly complex and weren't being handled well by Vite.

natemoo-re · 2022-02-08T22:37:04Z

packages/astro/src/runtime/server/hydration.ts

-		}
-	},
-};
+import serializeJavaScript from 'serialize-javascript';


This was replaced by serializeJavaScript which handles everything for us.

natemoo-re · 2022-02-08T22:37:52Z

packages/astro/src/vite-plugin-astro/index.ts

+					if (filename.startsWith('/@fs')) {
+						filename = filename.slice('/@fs'.length);
+					} else if (filename.startsWith('/') && !ancestor(filename, config.projectRoot.pathname)) {
+						filename = new URL('.' + filename, config.projectRoot).pathname;
+					}
+


@matthewp any idea if this was old code that snuck back in via a rebase?

FredKSchott

LGTM! What a huge effort @natemoo-re !

Just a callout that this will be released as npm install astro@next before it goes out to everyone, so there will be time to test with real-user data post-merge.

jonathantneal

For what this change is, it was surprising clear. Well done, @natemoo-re!

* chore: unvendor vite * chore: upgrade vue and svelte * feat(renderer-solid): upgrade for [email protected] * chore: update yarn.lock * fix(solid): upgrade solid renderer for [email protected] * test: improve css test * chore: upgrade to [email protected] * fix: replace hacky serialization with 'serialize-javascript' * fix: externalize serialize-javascript * fix: explicitly add [email protected] to devDependencies * test(css): skip css?url test * chore: update vite-plugin-svelte * fix: ssr option * chore: update changeset * chore: remove changeset * chore: add changeset * chore: add back missing changeset * chore: update vite * chore: update to latest vite * test: update proload? * chore: update dependencies * fix: remove preact from nanostores example * fix: update static-build-pkg to use `.mjs` extension * fix: exclude './server.js' from custom-elements test * chore: remove unused file

github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) test labels Jan 19, 2022

natemoo-re mentioned this pull request Jan 19, 2022

update to [email protected] #1866

Closed

natemoo-re marked this pull request as draft January 19, 2022 23:38

natemoo-re mentioned this pull request Jan 19, 2022

🐛 BUG: process.env.XXX not accessible #2244

Closed

natemoo-re changed the title ~~Upgrade to [email protected]~~ Upgrade Vite to latest Jan 19, 2022

FredKSchott assigned natemoo-re Jan 20, 2022

natemoo-re force-pushed the chore/upgrade-vite branch from f5f268c to 22c44e1 Compare January 24, 2022 20:41

jonathantneal changed the title ~~Upgrade Vite to latest~~ [WIP] Upgrade Vite to latest Jan 25, 2022

natemoo-re force-pushed the chore/upgrade-vite branch 3 times, most recently from 228f74a to 56f75c1 Compare January 31, 2022 21:31

FredKSchott mentioned this pull request Feb 2, 2022

🐛 BUG: fsonathan... Vite error when using fs in external files #2389

Closed

natemoo-re force-pushed the chore/upgrade-vite branch from 1d1870f to ab3ee62 Compare February 4, 2022 22:52

natemoo-re force-pushed the chore/upgrade-vite branch from 611c81a to a950a47 Compare February 8, 2022 15:51

github-actions bot added the pkg: example Related to an example package (scope) label Feb 8, 2022

natemoo-re marked this pull request as ready for review February 8, 2022 21:37

natemoo-re changed the title ~~[WIP] Upgrade Vite to latest~~ Upgrade Vite to latest Feb 8, 2022

natemoo-re commented Feb 8, 2022

View reviewed changes

Nate Moore added 22 commits February 8, 2022 16:52

chore: update yarn.lock

7558ba5

fix(solid): upgrade solid renderer for [email protected]

2c4d345

test: improve css test

b73a3b2

chore: upgrade to [email protected]

bc4be8a

fix: replace hacky serialization with 'serialize-javascript'

e2685d2

fix: externalize serialize-javascript

fa8fe77

fix: explicitly add [email protected] to devDependencies

9d1d23a

test(css): skip css?url test

69805ec

chore: update vite-plugin-svelte

3096ded

fix: ssr option

2fda826

chore: update changeset

d7f2141

chore: remove changeset

c9ab133

chore: add changeset

cc199b9

chore: add back missing changeset

d76e9f0

chore: update vite

9ffc343

chore: update to latest vite

ccfc10e

test: update proload?

c0894c9

chore: update dependencies

9552a32

fix: remove preact from nanostores example

9e3859b

fix: update static-build-pkg to use .mjs extension

2511328

fix: exclude './server.js' from custom-elements test

e2f4ba4

chore: remove unused file

7d1479b

natemoo-re force-pushed the chore/upgrade-vite branch from 0ea516a to 7d1479b Compare February 8, 2022 22:52

FredKSchott approved these changes Feb 8, 2022

View reviewed changes

jonathantneal approved these changes Feb 8, 2022

View reviewed changes

natemoo-re merged commit 1abb9ed into main Feb 8, 2022

natemoo-re deleted the chore/upgrade-vite branch February 8, 2022 23:38

github-actions bot mentioned this pull request Feb 8, 2022

[ci] release (next) #2555

Merged

github-actions bot mentioned this pull request Feb 18, 2022

[ci] release #2619

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Vite to latest #2424

Upgrade Vite to latest #2424

natemoo-re commented Jan 19, 2022 •

edited

Loading

changeset-bot bot commented Jan 19, 2022 •

edited

Loading

netlify bot commented Jan 19, 2022 •

edited

Loading

matthewp commented Jan 20, 2022

matthewp commented Jan 21, 2022

matthewp commented Jan 21, 2022

natemoo-re commented Jan 24, 2022

natemoo-re commented Feb 5, 2022

natemoo-re Feb 8, 2022

FredKSchott Feb 8, 2022

natemoo-re Feb 8, 2022

natemoo-re Feb 8, 2022

natemoo-re Feb 8, 2022

natemoo-re Feb 8, 2022

natemoo-re Feb 8, 2022

FredKSchott left a comment

jonathantneal left a comment

		import { valueToEstree } from 'estree-util-value-to-estree';
		import * as astring from 'astring';

Upgrade Vite to latest #2424

Upgrade Vite to latest #2424

Conversation

natemoo-re commented Jan 19, 2022 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Jan 19, 2022 • edited Loading

🦋 Changeset detected

netlify bot commented Jan 19, 2022 • edited Loading

matthewp commented Jan 20, 2022

matthewp commented Jan 21, 2022

matthewp commented Jan 21, 2022

natemoo-re commented Jan 24, 2022

natemoo-re commented Feb 5, 2022

natemoo-re Feb 8, 2022

Choose a reason for hiding this comment

FredKSchott Feb 8, 2022

Choose a reason for hiding this comment

natemoo-re Feb 8, 2022

Choose a reason for hiding this comment

natemoo-re Feb 8, 2022

Choose a reason for hiding this comment

natemoo-re Feb 8, 2022

Choose a reason for hiding this comment

natemoo-re Feb 8, 2022

Choose a reason for hiding this comment

natemoo-re Feb 8, 2022

Choose a reason for hiding this comment

FredKSchott left a comment

Choose a reason for hiding this comment

jonathantneal left a comment

Choose a reason for hiding this comment

natemoo-re commented Jan 19, 2022 •

edited

Loading

changeset-bot bot commented Jan 19, 2022 •

edited

Loading

netlify bot commented Jan 19, 2022 •

edited

Loading