Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hydrated components in the static build #2260

Merged
merged 12 commits into from
Dec 30, 2021

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 23, 2021

Changes

  • This removes vite postprocessing for the static build
  • Also gets hydrated components working
  • Note that the normal build is unaffected.

Testing

Fast build demo is being used as the test as of now.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2021

⚠️ No Changeset found

Latest commit: 90113cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: vue Related to Vue (scope) feat: markdown Related to Markdown (scope) pkg: integration Related to any renderer integration (scope) labels Dec 23, 2021
@github-actions github-actions bot removed pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope) labels Dec 28, 2021
@netlify
Copy link

netlify bot commented Dec 28, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: c8c3e8d

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61cb47fbf4c4c200074ab42f

😎 Browse the preview: https://deploy-preview-2260--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Dec 28, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: c8c3e8d

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61cb47fb7c00f30007661eb2

😎 Browse the preview: https://deploy-preview-2260--astro-docs-2.netlify.app

@github-actions github-actions bot added the test label Dec 28, 2021
@matthewp matthewp force-pushed the no-more-vite-postprocess3 branch from d866a26 to c8c3e8d Compare December 28, 2021 17:23
@github-actions github-actions bot removed the feat: markdown Related to Markdown (scope) label Dec 28, 2021
@matthewp matthewp force-pushed the no-more-vite-postprocess3 branch from c337f61 to 90113cc Compare December 29, 2021 13:59
@matthewp matthewp changed the title Remove vite postprocessing Implement hydrated components in the static build Dec 29, 2021
@matthewp matthewp marked this pull request as ready for review December 29, 2021 14:08
Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate that it comes with a fast-build.

@matthewp matthewp merged commit ae5255d into main Dec 30, 2021
@matthewp matthewp deleted the no-more-vite-postprocess3 branch December 30, 2021 14:01
matthewp added a commit that referenced this pull request Dec 30, 2021
matthewp added a commit that referenced this pull request Dec 30, 2021
…2292)

* Revert "Implement hydrated components in the static build (#2260)"

This reverts commit ae5255d.

* Adds a changeset
matthewp added a commit that referenced this pull request Jan 4, 2022
matthewp added a commit that referenced this pull request Jan 4, 2022
* Revert "Revert "Implement hydrated components in the static build (#2260)""

This reverts commit 17ac18e.

* Only resolve specifiers in the static build

* Adding a changeset

* Fix the client-only test
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Work on removing vite-postprocess

* Gets hydration totally working

* Formatting

* Update based on PR comments

* Bring back vite transform for non-static builds

* Upgrade compiler version

* Update the client-only test

* Add debugging for windows

* More debugging

* Pass pathname into the markdown plugin as well

* Include vite changes

* Revert "Include vite changes"

This reverts commit dee6348.
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
…2260)" (withastro#2292)

* Revert "Implement hydrated components in the static build (withastro#2260)"

This reverts commit ae5255d.

* Adds a changeset
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
…2302)

* Revert "Revert "Implement hydrated components in the static build (withastro#2260)""

This reverts commit 17ac18e.

* Only resolve specifiers in the static build

* Adding a changeset

* Fix the client-only test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants