fix(routing): skip middleware for external redirects #13133
Merged
+71
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg: astro
ematipico
force-pushed
the
fix/static-redirect
branch
from
94a9703 to
ed3a753
Compare
🦋 Changeset detectedLatest commit: 7f005a7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ascorbic
reviewed
Feb 4, 2025
ascorbic
approved these changes
Feb 4, 2025
CodSpeed Performance ReportMerging #13133 will not alter performanceComparing Summary
|
Co-authored-by: Matt Kane <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #13120
The fix is inside
RenderContext, and now check if the route that we are about to render is an external redirect. If it is, we skip the whole middleware chain, and render the redirect straight away.I checked with Matt and Florian, and they agree with the proposed solution.
Testing
I added a new test and fixture based on the reproduction provided.
Docs
N/A