Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for react-compiler-runtime #12735

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

stipsan
Copy link
Contributor

@stipsan stipsan commented Dec 13, 2024

Changes

Adds support for libraries publishing code pre-compiled with the React Compiler

Testing

Don't know enough about astro internals to add a test 🤷

Docs

Don't think docs need to change, support for react-compiler-runtime is just expected to work, same way the react/jsx-runtime is.

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 0764e5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Dec 13, 2024
@matthewp
Copy link
Contributor

lgtm, waiting for confirmation from the Sanity team that this fixes the bug they are experiencing.

@matthewp
Copy link
Contributor

They were able to confirm. Thanks again!

@matthewp matthewp merged commit 0ac0f25 into withastro:main Dec 16, 2024
14 checks passed
@matthewp
Copy link
Contributor

I forgot to add a changeset here, so I did so here instead: #12755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants