fix: correctly copy to clipboard in astro info
#12641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8063bee The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #12641 will not alter performanceComparing Summary
|
ascorbic
changed the title
astro info
ematipico
approved these changes
Dec 5, 2024
packages/astro/src/cli/info/index.ts
Outdated
| throw result.error; | ||
| } | ||
| console.log(colors.green('Copied to clipboard!')); | ||
| } catch (err) { |
There was a problem hiding this comment.
Unused (thank you github annotations)
packages/astro/src/cli/info/index.ts
Outdated
| if (!shouldCopy) return; | ||
| if (!command) { | ||
| console.error(colors.red('\nClipboard command not found!')); | ||
| console.log('Please manually copy the text above.'); |
There was a problem hiding this comment.
Use .info instead. Usually .log is more for debugging
packages/astro/src/cli/info/index.ts
Outdated
| if (result.error) { | ||
| throw result.error; | ||
| } | ||
| console.log(colors.green('Copied to clipboard!')); |
Co-authored-by: Emanuele Stoppa <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro infocopy to clipboard has not been working on Mac because piping the input topbcopyusingexecSyncseems to not work. This PR fixes that by switching tospawnSyncinstead ofexecSync. It also adds a helper to read from the clipboard so we can check it works across platforms, and adds support for a--copyflag to avoid needing to prompt.Fixes #12639
Testing
Adds a new test suite.
Docs