Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up content layer sync in build and sync api #12633

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 4, 2024

Changes

In build (and sync() programmatic API), the content layer singleton is disposed since we only usually need to init and sync it once. This could free a bit of memory (but I think not by a lot).

Testing

Existing tests should pass

Docs

n/a. refactor

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 4eb5753

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #12633 will not alter performance

Comparing layer-sync-build (4eb5753) with main (176fe9f)

Summary

✅ 6 untouched benchmarks

@bluwy bluwy merged commit 8a551c1 into main Dec 5, 2024
16 checks passed
@bluwy bluwy deleted the layer-sync-build branch December 5, 2024 10:13
@astrobot-houston astrobot-houston mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants