Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make image endpoint highest priority #12591

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix: make image endpoint highest priority #12591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e4f57d
fix: make image endpoint highest priority
ascorbic Dec 3, 2024
85298fe
Use config for endpoint
ascorbic Dec 3, 2024
e8e5a78
Add test
ascorbic Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plenty-carrots-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes a bug where a catchall route would match an image endpoint request
4 changes: 2 additions & 2 deletions packages/astro/src/assets/endpoint/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function injectImageEndpoint(
mode: 'dev' | 'build',
cwd?: string,
) {
manifest.routes.push(getImageEndpointData(settings, mode, cwd));
manifest.routes.unshift(getImageEndpointData(settings, mode, cwd));
}

export function ensureImageEndpointRoute(
Expand All @@ -23,7 +23,7 @@ export function ensureImageEndpointRoute(
cwd?: string,
) {
if (!manifest.routes.some((route) => route.route === '/_image')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this condition is probably not good, you can change the path of the image endpoint. It should use the config to find the path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. A different issue but we can include it in this

manifest.routes.push(getImageEndpointData(settings, mode, cwd));
manifest.routes.unshift(getImageEndpointData(settings, mode, cwd));
}
}

Expand Down
Loading