Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate types even without src/content #12565

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix: generate types even without src/content #12565

merged 2 commits into from
Nov 29, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Nov 29, 2024

Changes

Currently we're only referencing the content types in dev if the content dir exists. Since we no longer require that, in many cases this wasn't being generated. This PR changes the logic to ensure it's always created when needed.

Fixes #12555

Testing

Added a test

Docs

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 731bf50

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 29, 2024
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #12565 will degrade performances by 14.18%

Comparing typegen-dev (a09229e) with main (c50882d)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main typegen-dev Change
Rendering: streaming [false], .astro file 1.5 s 1.7 s -13.13%
Rendering: streaming [false], .md file 22.4 ms 15 ms +49.18%
Rendering: streaming [false], .mdx file 1 s 1.2 s -14.18%

@ascorbic ascorbic marked this pull request as ready for review November 29, 2024 15:39
@ascorbic ascorbic merged commit 97f413f into main Nov 29, 2024
15 of 16 checks passed
@ascorbic ascorbic deleted the typegen-dev branch November 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Astro type definition references
2 participants