Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node 22 in CI #12540

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Use node 22 in CI #12540

merged 1 commit into from
Nov 27, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 27, 2024

Changes

Use node 22 instead of 18 since 22 is now the active LTS. Also added a new matrix to test ubuntu and node 22.

Theoretically it should be a little faster with node's recent perf improvements.

Testing

CI should pass

Docs

n/a

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 4753318

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Nov 27, 2024
@ematipico
Copy link
Member

I don't think we should drop v18 yet (for macOS and Windows). We state that we still support it, so the CI should reflect that in case we break something.

@bluwy
Copy link
Member Author

bluwy commented Nov 27, 2024

Wouldn't the same apply for node 20 and 22? Both have breaking changes which could not work in Astro, so they could be useful to be tested. But to not bloat our matrix we'd have to pick one between 18, 20, and 22, and picking v22 as the baseline as its the active LTS seems ok to me 🤔 Or do we want to test against the oldest supported LTS only?

@ematipico
Copy link
Member

Now that I think about about, I believe we shouldn't support v18 anymore. Our semver says latest Maintenance LTS.

At the moment, there are two maintenance LTS, and the latest is v20. Did I get it right? If so, should we drop node v18?

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this PR, I don't have strong concerns that should block the PR

@bluwy bluwy merged commit 6f47936 into main Nov 27, 2024
15 checks passed
@bluwy bluwy deleted the node-22-ci branch November 27, 2024 16:00
@delucis delucis mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants