Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Action query param to _action #12510

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

bholmesdev
Copy link
Contributor

Changes

Renames the generated _astroAction query param to _action when using HTML form actions. Some developers may prefer to avoid leaking the framework name into the URL bar, so I expect this to be a better default. If the name _action proves challenging for conflicts, we can investigate an astro.config option.

Testing

Update const and ensure tests still pass.

Docs

N/A - not documented

@bholmesdev bholmesdev marked this pull request as ready for review November 22, 2024 22:47
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: f5c5da6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Nov 22, 2024
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Nov 22, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@ematipico ematipico merged commit 14feaf3 into next Nov 25, 2024
13 checks passed
@ematipico ematipico deleted the rename-action-query-param branch November 25, 2024 08:43
This was referenced Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants