Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix astro add generated import identifier #12362

Closed
wants to merge 2 commits into from

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Nov 2, 2024

Changes

Testing

I didn't find tests for the astro add command. It seems wild to add test for the whole thing on a PR for a tiny change like this

Docs

N/A

Copy link

changeset-bot bot commented Nov 2, 2024

⚠️ No Changeset found

Latest commit: 71827fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 2, 2024
@bluwy
Copy link
Member

bluwy commented Nov 4, 2024

We don't need the same fixes made to next. We'll periodically merge updates from main into next before releasing the beta.

@Fryuni
Copy link
Member Author

Fryuni commented Nov 6, 2024

Got it, in that case we can close this.

@Fryuni Fryuni closed this Nov 6, 2024
@Fryuni Fryuni deleted the fryuni/astro-add-version-packages branch November 6, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants